wireshark-dev October 2010 archive
Main Archive Page > Month Archives  > wireshark-dev archives
wireshark-dev: Re: [Wireshark-dev] deprecating check_col()

Re: [Wireshark-dev] deprecating check_col()

From: Stig Bjørlykke <stig_at_nospam>
Date: Fri Oct 22 2010 - 13:49:47 GMT
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>

On Fri, Oct 22, 2010 at 3:44 PM, Jeff Morriss <jeff.morriss.ws@gmail.com> wrote:
> Should we discuss the concept of removing all check_col()'s again? In
> looking at the PPP dissector, for example, it seems there may be a fair
> amount of work saved by keeping them.

My intention behind putting this check in all col_* functions was that
you do not _need_ to use check_col(), but may use it if something
needs to be calculated before put in a column. So a case-by-case
basis sounds right to me.

-- Stig Bjørlykke ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe