wireshark-dev August 2010 archive
Main Archive Page > Month Archives  > wireshark-dev archives
wireshark-dev: Re: [Wireshark-dev] Remove old packet list code i

Re: [Wireshark-dev] Remove old packet list code in trunk?

From: Anders Broman <anders.broman_at_nospam>
Date: Wed Aug 18 2010 - 09:14:43 GMT
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>

 

>-----Original Message-----
>From: wireshark-dev-bounces@wireshark.org [mailto:wireshark-dev-bounces@wireshark.org] On Behalf Of Jaap Keuter
>Sent: den 18 augusti 2010 11:02
>To: Developer support list for Wireshark
>Subject: Re: [Wireshark-dev] Remove old packet list code in trunk?
>
>Hi,
>
>Mind you that it would make back porting to trunk-1.4 of packet list related code more difficult since the
>source code will diverge.
>That means more manual back porting, which is more laborious and error prone (sorry Gerald).
>
>I would suggest holding off on stripping trunk of old packet list code, but not to maintain it. After we put >1.4.1 'in the wild' and survives real user scrutiny it time to start ripping it out IMHO.
>
>Thanks,
>Jaap

I agree with you, just to be clear not having NEW_PACKET_LIST defined is not expected to
Work in trunk any more. Perhapps adding comments about that and/or change it to #if 0 if edditing a file for
Other reasons?
Regards
Anders

>
>On Wed, 18 Aug 2010 07:40:08 +0200, Anders Broman <a.broman@telia.com>
>wrote:
>> Hi,
>> In bug 5115 the question is raised if we should remove the "old packet
>> list" code as it becomes cumbersome to write code for both branches in
>> some cases. With the upcoming release of 1.4 I suppose we might as
>> well remove the code in trunk.
>> Regards
>> Anders
>>

___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe