spamassassin-dev November 2011 archive
Main Archive Page > Month Archives  > spamassassin-dev archives
spamassassin-dev: [Bug 6698] New DCC.pm improves performance, is

[Bug 6698] New DCC.pm improves performance, is more resilient.

From: <bugzilla-daemon_at_nospam>
Date: Mon Nov 14 2011 - 20:48:35 GMT
To: dev@spamassassin.apache.org

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6698

--- Comment #11 from Vernon Schryver <vjs@rhyolite.com> 2011-11-14 20:48:35 UTC ---
> I left in both, added some debugging, and streamlined a bit.
> Please see what came out (svn diff -c1201835) :

Because
     $conf->{dcc_home}
can be undefined, I think you really need something like
     my $home = $conf->{dcc_home} || '/var/dcc';
and then using $home instead of $conf->{dcc_home} in line 516.
If the user has not set $conf->{dcc_home}, won't you at best
get undesired results from such as
     ($conf->{dcc_home}.'/bin'
There is a similar prlbme with the use of $conf->{dcc_libexec}
in line 516 that will cause surprises or perl interpreter
croaking in line 518 if $conf->{dcc_libexec} is not defined by
the user.

I don't understand how some of the changes to regular
expressions or replacing
     if ($x) {
with
     if (defined $x && $x ne '') {
qualifies as streamlining, but there's no accounting for
tastes and it's now your code.

-- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.