spamassassin-dev November 2011 archive
Main Archive Page > Month Archives  > spamassassin-dev archives
spamassassin-dev: [Bug 6698] New DCC.pm improves performance, is

[Bug 6698] New DCC.pm improves performance, is more resilient.

From: <bugzilla-daemon_at_nospam>
Date: Mon Nov 14 2011 - 19:27:44 GMT
To: dev@spamassassin.apache.org

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6698

--- Comment #10 from Mark Martinec <Mark.Martinec@ijs.si> 2011-11-14 19:27:44 UTC ---
> There is a minor issue with the committed change. Line 523 is now
> $pgmpath = '/var/dcc/' . $pgm;
> I think it should be the value that can see in
> http://www.dcc-servers.net/dcc/dcc-tree/misc/DCC.pm
> $pgmpath = '/usr/local/dcc/' . $pgm;
> Or the /var/dcc/ line could be kept and these 2 lines added
> $pgmpath = '/usr/local/dcc/' . $pgm;
> return $pgmpath if -x $pgmpath;
>
> The intent in using /usr/local/dcc was to look in a common
> choice for the DCC `./configure --bindir=DIR` value.
> The default value is /usr/local/bin

I left in both, added some debugging, and streamlined a bit.
Please see what came out (svn diff -c1201835) :

trunk:
  Bug 6698#9: New DCC.pm improves performance, is more resilient'
  Sending lib/Mail/SpamAssassin/Plugin/DCC.pm
Committed revision 1201835.

> A separate issue is what should be done with the copy of DCC.pm
> that has been in versions of DCC for the last 18 months.
> It's always asking for trouble to have 2 copies of a value,

Agree. As the DCC.pm plugin is only usable with SpamAssassin,
and has been distributed with it since I remember, I see no point
of having another copy of this plugin distributed with dcc.

> not to mention code. I could remove the copy in the DCC source
> after the SpamAssassin version is released. When might that be?

Soon ;)

> I expect to make a DCC release in the next few months.
> Deleting the copy of DCC.pm in the DCC source would inconvenience
> installations that are looking in the DCC tarball for DCC.pm.
> Some of them are using the fact that the DCC version of DCC.pm
> is actually generated by the DCC ./configure script. See
> http://www.dcc-servers.net/dcc/dcc-tree/misc/DCC.pm.in
> Do you have any suggestions?

I think it is mostly up to you to decide. I'd ditch the DCC.pm.in .

-- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.